Filter out statistics of deleted teams #11973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
requested changes
Mar 6, 2025
| @@ -30,6 +31,7 @@ public function testDelete(): void | |||
| $team->members()->create(['user_id' => User::factory()->create()->getKey()]); | |||
| Chat\Message::factory()->create(['channel_id' => $team->channel, 'user_id' => $team->leader_id]); | |||
| $team->applications()->create(['user_id' => User::factory()->create()->getKey()]); | |||
| $team->statistics()->create(['ruleset_id' => 0]); | |||
There was a problem hiding this comment.
other team in the test should also have statistics (and probably add applications as well)
|
I'll add that tomorrow... (also the ranking page is currently occasionally broken btw) |
notbakaneko
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot about this case of deleted team on ranking page...
Either this or just delete the statistics when the team is deleted 🤔 That one sounds betterhow about both