Show statistics on team page #11979
Merged
Show statistics on team page #11979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
requested changes
Mar 7, 2025
app/Models/TeamStatistics.php
Outdated
| @@ -27,6 +34,14 @@ public function members(): HasMany | |||
| return $this->hasMany(TeamMember::class, 'team_id', 'team_id'); | |||
| } | |||
|
|
|||
| public function getRank(): int | |||
There was a problem hiding this comment.
should teams even have a rank if they have no plays or score on a ruleset?
notbakaneko
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe? 🤔
Kinda took the original design but the stats are different and there isn't enough stuff to fill the section so I moved the existing info there and made team custom page its own section just like profile page.
Also matched section title and stuff from profile page.
the page is kinda long and sparse now