-
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: output css source map #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 535a384 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Test suite will need an adjustment for the new map files being output. Will be added here:
Not quite sure what that failure on the publicPath test is, might be Critters doing something differently with these changes. |
Is filesize some random value or should I produce build to get it? If latter, how do I do it? Just run clean installation? |
You'll need to run a build to get it. The test ensures that file is +/5% of the listed value. Unfortunately it's a bit of a pain in the ass to generate, could never figure out a way to automate it. Easiest way is to only run the one build test and get the file size from the directory that's created. |
I'll take care of it in a few minutes, it's a faff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, tracking down the solution, AND implementing! I really appreciate it!
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
Summary
#1793
Does this PR introduce a breaking change?
no