Skip to content

fix: output css source map #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Conversation

teodragovic
Copy link
Contributor

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

no

Summary

#1793

Does this PR introduce a breaking change?

no

@teodragovic teodragovic requested a review from a team as a code owner June 30, 2023 08:56
@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

🦋 Changeset detected

Latest commit: 535a384

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rschristian
Copy link
Member

Test suite will need an adjustment for the new map files being output. Will be added here:

exports.default = Object.assign({}, common, {

Not quite sure what that failure on the publicPath test is, might be Critters doing something differently with these changes.

@teodragovic
Copy link
Contributor Author

Is filesize some random value or should I produce build to get it? If latter, how do I do it? Just run clean installation?

@rschristian
Copy link
Member

You'll need to run a build to get it. The test ensures that file is +/5% of the listed value.

Unfortunately it's a bit of a pain in the ass to generate, could never figure out a way to automate it. Easiest way is to only run the one build test and get the file size from the directory that's created.

@rschristian
Copy link
Member

I'll take care of it in a few minutes, it's a faff

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, tracking down the solution, AND implementing! I really appreciate it!

@rschristian rschristian linked an issue Jun 30, 2023 that may be closed by this pull request
@rschristian rschristian merged commit 047837d into preactjs:master Jun 30, 2023
@preact-bot preact-bot mentioned this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS source maps missing in build output
2 participants