Resolves issue with similar timeout and auto refresh value #1093
+50
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanylov-sigma
force-pushed
the
1028-autorefresh-timeout-issue
branch
from
436c83e to
872d866
Compare
| bidRequester.requestBids { [weak self] bidResponse, error in | ||
| timeoutHandler.cancel() |
There was a problem hiding this comment.
The solution looks great! Could you please consider adding some unit tests for this?
mdanylov-sigma
force-pushed
the
1028-autorefresh-timeout-issue
branch
from
32250e5 to
44d6f86
Compare
mdanylov-sigma
force-pushed
the
1028-autorefresh-timeout-issue
branch
from
44d6f86 to
0458004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1028
Resolves the corner case, when
timeoutequals toautoRefreshTime, which triggers new demand request and previously scheduled dispatch queue task simultaneously.