Rubicon: Update segtax logic #3915

CTMBNara · 2024-09-12T13:06:54Z

No description provided.

…ax-logic # Conflicts: # go.sum

…ax-logic

github-actions · 2024-10-14T16:50:20Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2a60290

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:187:	resolveVideoSizeId			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:205:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:221:	Builder					100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:233:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:258:	MakeRequests				81.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:575:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:594:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:613:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:650:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:658:	updateImpRpTarget			81.8%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:763:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:773:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:777:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:781:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:785:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:815:	updateExtWithIabAndSegtaxAttribute	100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:829:	getTaxonomyIdToSegments			86.4%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:868:	pickRelevantSegments			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:900:	groupSegments				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:917:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:945:	isStringArray				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:955:	isBoolArray				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:965:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:976:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:984:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:993:	contains				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1002:	isVideo					100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1011:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1016:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1048:	setImpNative				82.4%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1077:	MakeBids				92.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1177:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1195:	resolveAdm				87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1210:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1219:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				85.7%

CTMBNara · 2024-10-15T12:11:56Z

Can anyone help why this isn't working? Locally all tests pass

bsardo · 2024-11-04T16:44:58Z

Hi @CTMBNara, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

…ax-logic # Conflicts: # adapters/rubicon/rubicon.go

github-actions · 2024-11-05T12:31:29Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, cbfa168

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:189:	resolveVideoSizeId			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:207:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:223:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:235:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:260:	MakeRequests				81.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:577:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:596:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:615:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:652:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:660:	updateImpRpTarget			81.8%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:765:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:775:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:779:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:783:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:787:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:817:	updateExtWithIabAndSegtaxAttribute	100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:831:	getTaxonomyIdToSegments			86.4%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:870:	pickRelevantSegments			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:902:	groupSegments				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:919:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:947:	isStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:957:	isBoolArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:967:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:978:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:986:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:995:	contains				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1004:	isVideo					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1013:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1018:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1050:	setImpNative				82.4%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1079:	MakeBids				92.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1179:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1197:	resolveAdm				87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1212:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1221:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				85.7%

bsardo · 2024-11-12T15:45:52Z

@MaksymTeqBlaze can you please review?

This reverts commit 6e3a0d5.

Co-authored-by: ddubyk <ddubyk@magnite.com>

This reverts commit 6e3a0d5.

Update segtax logic.

347fb6b

CTMBNara requested a review from VeronikaSolovei9 September 12, 2024 13:06

Merge remote-tracking branch 'origin/master' into rubicon/update-segt…

05af985

…ax-logic # Conflicts: # go.sum

CTMBNara added the do not port label Sep 13, 2024

ddubyk added 2 commits October 14, 2024 18:44

Merge remote-tracking branch 'origin/master' into rubicon/update-segt…

26c87f2

…ax-logic

Fix tests.

2a60290

Merge remote-tracking branch 'origin/master' into rubicon/update-segt…

cbfa168

…ax-logic # Conflicts: # adapters/rubicon/rubicon.go

CTMBNara requested a review from bsardo November 5, 2024 12:31

bsardo assigned PyjamaWarrior Nov 13, 2024

bsardo assigned MaksymTeqBlaze and unassigned PyjamaWarrior Nov 20, 2024

bsardo assigned VeronikaSolovei9 Dec 11, 2024

VeronikaSolovei9 approved these changes Dec 12, 2024

View reviewed changes

MaksymTeqBlaze approved these changes Dec 18, 2024

View reviewed changes

bsardo added the adapter label Jan 6, 2025

bsardo merged commit 6e3a0d5 into master Jan 8, 2025
7 checks passed

bsardo mentioned this pull request Jan 8, 2025

Fix: Rubicon segtax test #4143

Merged

bsardo added a commit to bsardo/prebid-server that referenced this pull request Jan 17, 2025

Revert "Rubicon: Update segtax logic (prebid#3915)"

cd04a0c

This reverts commit 6e3a0d5.

bsardo added a commit that referenced this pull request Jan 18, 2025

Revert "Rubicon: Update segtax logic (#3915)" (#4161)

9d0b27e

This reverts commit 6e3a0d5.

CTMBNara mentioned this pull request Feb 18, 2025

Rubicon: Update segtax logic #4224

Open

scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Mar 24, 2025

Rubicon: Update segtax logic (prebid#3915)

c9ee007

Co-authored-by: ddubyk <ddubyk@magnite.com>

scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Mar 24, 2025

Revert "Rubicon: Update segtax logic (prebid#3915)" (prebid#4161)

1956e4c

This reverts commit 6e3a0d5.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rubicon: Update segtax logic #3915

Rubicon: Update segtax logic #3915

CTMBNara commented Sep 12, 2024

github-actions bot commented Oct 14, 2024

CTMBNara commented Oct 15, 2024

bsardo commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

bsardo commented Nov 12, 2024 •

edited

Loading

Rubicon: Update segtax logic #3915

Rubicon: Update segtax logic #3915

Conversation

CTMBNara commented Sep 12, 2024

github-actions bot commented Oct 14, 2024

Code coverage summary

rubicon

CTMBNara commented Oct 15, 2024

bsardo commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

Code coverage summary

rubicon

bsardo commented Nov 12, 2024 • edited Loading

bsardo commented Nov 12, 2024 •

edited

Loading