Connatix: Add viewability field #4168
Merged
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
monicaroxanabota
changed the title
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
karimMourra
approved these changes
Jan 20, 2025
monicaroxanabota
changed the title
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
monicaroxanabota
force-pushed
the
master
branch
from
abaaced to
216311a
Compare
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
karimMourra
approved these changes
Jan 21, 2025
bsardo
changed the title
guscarreon
reviewed
Feb 6, 2025
| }, | ||
| "viewabilityPercentage": { | ||
| "type": "number", | ||
| "description": "Declared viewability percentage (values from 0 to 1, where 1 = 100%)" |
There was a problem hiding this comment.
If viewabilityPercentage's value should range from 0 to 1, should we specify a minimum and a maximum?
12 "viewabilityPercentage": {
13 "type": "number",
14 "description": "Declared viewability percentage (values from 0 to 1, where 1 = 100%)"
+ "minimum": 0,
+ "maximum": 1
15 }
16 },
static/bidder-params/connatix.json
If not, is a validation inside adapters/connatix/connatix.go desired?
There was a problem hiding this comment.
I don’t want to enforce this because is handled on our side.
| @@ -199,7 +199,8 @@ func buildRequestImp(imp *openrtb2.Imp, ext impExtIncoming, displayManagerVer st | |||
|
|
|||
| impExt := impExt{ | |||
| Connatix: impExtConnatix{ | |||
| PlacementId: ext.Bidder.PlacementId, | |||
| PlacementId: ext.Bidder.PlacementId, | |||
| ViewabilityPercentage: ext.Bidder.ViewabilityPercentage, | |||
There was a problem hiding this comment.
If ViewabilityPercentage's value should range from 0 to 1, should we place a validation somewhere? If not in static/bidder-params/connatix.json, here just before assigning?
There was a problem hiding this comment.
I don’t want to enforce this because is handled on our side and should not block the request.
bsardo
approved these changes
Feb 11, 2025
20 tasks
scr-oath
pushed a commit
to scr-oath/prebid-server
that referenced
this pull request
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ViewabilityPercentage for connatix adaptor