Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Monetix Ads - Admatic alias #4215

Merged
merged 80 commits into from
Mar 13, 2025

Conversation

bakicam
Copy link
Contributor

@bakicam bakicam commented Feb 14, 2025

@bsardo bsardo added the adapter label Feb 14, 2025
@bsardo
Copy link
Collaborator

bsardo commented Mar 6, 2025

@pm-isha-bharti can you please review?

@@ -0,0 +1,3 @@
aliasOf: "admatic"
maintainer:
email: "team@monetixads.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent an email for confirmation, please respond with "received"

Copy link
Contributor

@pm-isha-bharti pm-isha-bharti Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

@@ -0,0 +1,3 @@
aliasOf: "admatic"
maintainer:
email: "publishers-support@netaddiction.it"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise a separate PR for each of the new alias you are contributing. This is helpful in maintenance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-isha-bharti What should I do for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-isha-bharti We removed these

@@ -0,0 +1,3 @@
aliasOf: "admatic"
maintainer:
email: "prebid@pixad.com.tr"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please raise a separate PR for each of the new alias you are contributing. This is helpful in maintenance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-isha-bharti What should I do for this?

Copy link
Contributor

@pm-isha-bharti pm-isha-bharti Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this yaml file from this PR and create a new PR for the same? Same goes for netaddiction

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-isha-bharti We removed these

@bsardo bsardo merged commit dbe41e4 into prebid:master Mar 13, 2025
4 checks passed
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Mar 24, 2025
Co-authored-by: Faruk Çam <mail@farukix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants