-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: Monetix Ads - Admatic alias #4215
Conversation
@pm-isha-bharti can you please review? |
@@ -0,0 +1,3 @@ | |||
aliasOf: "admatic" | |||
maintainer: | |||
email: "team@monetixads.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent an email for confirmation, please respond with "received"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified
static/bidder-info/netaddiction.yaml
Outdated
@@ -0,0 +1,3 @@ | |||
aliasOf: "admatic" | |||
maintainer: | |||
email: "publishers-support@netaddiction.it" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please raise a separate PR for each of the new alias you are contributing. This is helpful in maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pm-isha-bharti What should I do for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pm-isha-bharti We removed these
static/bidder-info/pixad.yaml
Outdated
@@ -0,0 +1,3 @@ | |||
aliasOf: "admatic" | |||
maintainer: | |||
email: "prebid@pixad.com.tr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please raise a separate PR for each of the new alias you are contributing. This is helpful in maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pm-isha-bharti What should I do for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this yaml file from this PR and create a new PR for the same? Same goes for netaddiction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pm-isha-bharti We removed these
Co-authored-by: Faruk Çam <mail@farukix.com>
PR: prebid/prebid.github.io#5387