-
-
Notifications
You must be signed in to change notification settings - Fork 120
Tutorials on fluid-fluid coupling with the preCICE OpenFOAM adapter #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is already in a very good shape. Thanks for making it so clean and easy to review!
I think the only potentially interesting part is moving the flow-over-heated-plate-partitioned-flow
from a composition of explicit+implicit to a multi-implicit scheme (is possible and wanted). Everything else should be very easy & quick to adjust.
flow-over-heated-plate-partitioned-flow/fluid1-openfoam/system/decomposeParDict
Show resolved
Hide resolved
...plate-partitioned-flow/fluid2-openfoam/0/uniform/functionObjects/functionObjectProperties.gz
Outdated
Show resolved
Hide resolved
flow-over-heated-plate-partitioned-flow/fluid2-openfoam/system/blockMeshDict
Outdated
Show resolved
Hide resolved
Also here, regarding the linting issue (bare URL), just rebase on develop. |
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
We currently have the following situation:
@thesamriel Please add note alerts at the top of every tutorial, explaining the dependencies. I don't think we can have a new adapter release today, so refer to preCICE v2 and your adapter branch for now. |
Makes the tutorials introduced in precice/tutorials#326 discoverable
Makes the tutorials introduced in precice/tutorials#326 discoverable
This pull request updates and adds tutorials on fluid-fluid coupling with the OpenFOAM adapter.
Partitioned Pipe:
Partitioned Flow over Backwards Facing Step:
Flow over Heated Plate with Flow Partitioning:
Tutorials were tested with: