Skip to content

Tutorials on fluid-fluid coupling with the preCICE OpenFOAM adapter #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 13, 2023

Conversation

thesamriel
Copy link
Contributor

This pull request updates and adds tutorials on fluid-fluid coupling with the OpenFOAM adapter.

Partitioned Pipe:

  • Updated to use the ffep pressure boundary condition for pimpledFoam
  • Explain problems of a skewed mesh with demonstration

Partitioned Flow over Backwards Facing Step:

Flow over Heated Plate with Flow Partitioning:

  • modified flow-over-heated-plate tutorial with additional flow partitioning
  • Showcases compatibility of the FF module with the compressible solver buoyantPimpleFoam
  • Additional coupling of temperature
  • FF coupling is serial-implicit, CHT coupling serial-explicit

Tutorials were tested with:

  • OpenFOAM v2112
  • preCICE 2.5.0
  • openfoam adapter on branch develop-ff

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is already in a very good shape. Thanks for making it so clean and easy to review!

I think the only potentially interesting part is moving the flow-over-heated-plate-partitioned-flow from a composition of explicit+implicit to a multi-implicit scheme (is possible and wanted). Everything else should be very easy & quick to adjust.

@MakisH MakisH self-assigned this May 20, 2023
@thesamriel thesamriel requested a review from MakisH May 28, 2023 18:27
@MakisH
Copy link
Member

MakisH commented May 30, 2023

Also here, regarding the linting issue (bare URL), just rebase on develop.

@MakisH
Copy link
Member

MakisH commented Jun 6, 2023

We currently have the following situation:

  • These tutorials are compatible with preCICE v2, so this PR can be merged
  • However, the cases need a new OpenFOAM adapter release (or a specific branch) to work
  • At the same time, we have not yet updated the cases to work with preCICE develop. This, we can do in a separate PR.

@thesamriel Please add note alerts at the top of every tutorial, explaining the dependencies. I don't think we can have a new adapter release today, so refer to preCICE v2 and your adapter branch for now.

@MakisH MakisH merged commit 49c0a7e into develop Jun 13, 2023
@MakisH MakisH deleted the ff-tuts branch June 13, 2023 07:53
MakisH added a commit to precice/precice.github.io that referenced this pull request Jun 14, 2023
Makes the tutorials introduced in precice/tutorials#326 discoverable
uekerman pushed a commit to precice/precice.github.io that referenced this pull request Jun 14, 2023
Makes the tutorials introduced in precice/tutorials#326 discoverable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants