-
-
Notifications
You must be signed in to change notification settings - Fork 120
Add ability to compare fields #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Updated test syntax to include reference_results - introduced working generation of reference results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚲
Works on my machine (after checking out the precice-config.xml
from master
).
Some questions for me to better understand, not necessarily something to change. Please ask for review again when ready.
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some follow-ups are already in the project board, this can already be merged.
This PR introduces the ability to compare produced fields. Therefore necessary:
generate_reference_results.py
script.systemtests.py
This PR solves:
tests.yaml
to contain the reference files #351