Skip to content

Add ability to compare fields #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 14, 2023
Merged

Conversation

valentin-seitz
Copy link
Contributor

This PR introduces the ability to compare produced fields. Therefore necessary:

  • Introduced the generation of reference results via the generate_reference_results.py script.
  • Added .gitattributes for lfs storage of reference results archives
  • added correct exit status of systemtests.py

This PR solves:

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚲

Works on my machine (after checking out the precice-config.xml from master).

Some questions for me to better understand, not necessarily something to change. Please ask for review again when ready.

valentin-seitz and others added 2 commits August 14, 2023 10:37
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some follow-ups are already in the project board, this can already be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants