Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to continue building on failure when using --recipe-dir #1023

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add option to continue building on failure when using --recipe-dir #1023

wants to merge 2 commits into from

Conversation

KGB99
Copy link

@KGB99 KGB99 commented Aug 16, 2024

No description provided.

@KGB99 KGB99 mentioned this pull request Aug 16, 2024
Open
@KGB99
Copy link
Author

KGB99 commented Aug 16, 2024

I haven't figured out how to add the option to the CLI, any guidance is appreciated.

baszalmstra
baszalmstra requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need help with the CLI? Looks like you already managed to make it work?

@baszalmstra
Copy link
Contributor

Also, can you make sure that the program still exists with an exit code if one of the ouputs failed to build?

@KGB99
Copy link
Author

KGB99 commented Aug 16, 2024

Do you still need help with the CLI? Looks like you already managed to make it work?

Yes it seems to work, thank you, i used the wrong command from the CLI myself, so I was confused.

Also, can you make sure that the program still exists with an exit code if one of the ouputs failed to build?

This would be for a singular recipe right? I believe the latest commit includes that as well.

@KGB99 KGB99 marked this pull request as ready for review August 16, 2024 17:39
@KGB99 KGB99 requested a review from baszalmstra August 20, 2024 12:53
@baszalmstra
Copy link
Contributor

@wolfv Are you still interested in this PR? Should we upstream the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra Awaiting requested review from baszalmstra

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KGB99 @baszalmstra