-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support channel_sources
from variant configs
#1416
base: main
Are you sure you want to change the base?
Conversation
@wolfv, could you take the initial look at my approach? |
I am fine with this but it should definitely overwrite any default values, and probably even any CLI values. |
In my opinion, CLI should always take precedence — perhaps even override the values coming from configs. But it's your project, so I'm open to doing whatever you think best. |
Well, at least the default value should be gone. I am also fine with |
For now, this means that `channel_sources` override both the default of `conda-forge` and user-supplied channels. I will try changing this later, as it requires changes to the config logic.
Do you have a suggestion on how to test this? |
Besides the code being ugly, what I get now is:
I wonder if we should remove the
conda-forge
default when we're now reading channels from the variant configs.Fixes conda-forge/conda-smithy#2226