Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support channel_sources from variant configs #1416

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Feb 7, 2025

Besides the code being ugly, what I get now is:

 │ │   Channels: 
 │ │    - file:///var/tmp/conda-bld/
 │ │    - conda-forge/label/llvm_rc
 │ │    - conda-forge
 │ │    - conda-forge

I wonder if we should remove the conda-forge default when we're now reading channels from the variant configs.

Fixes conda-forge/conda-smithy#2226

@mgorny
Copy link
Contributor Author

mgorny commented Feb 18, 2025

@wolfv, could you take the initial look at my approach?

@wolfv
Copy link
Member

wolfv commented Feb 27, 2025

I am fine with this but it should definitely overwrite any default values, and probably even any CLI values.

@mgorny
Copy link
Contributor Author

mgorny commented Feb 27, 2025

In my opinion, CLI should always take precedence — perhaps even override the values coming from configs. But it's your project, so I'm open to doing whatever you think best.

@wolfv
Copy link
Member

wolfv commented Feb 27, 2025

Well, at least the default value should be gone. I am also fine with default -> variant -> CLI

For now, this means that `channel_sources` override both the default
of `conda-forge` and user-supplied channels.  I will try changing this
later, as it requires changes to the config logic.
@mgorny
Copy link
Contributor Author

mgorny commented Feb 27, 2025

Okay, I've made the channel_sources override both config/default for now. Adjusting it to the way I wanted it would require changing the config logic somewhat, so I'll take a look at it later. Solved it.

Do you have a suggestion on how to test this?

@mgorny mgorny marked this pull request as ready for review March 5, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 recipe and channel_sources and priority
3 participants