Skip to content

install py-3.11 for sync #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KPostOffice
Copy link
Collaborator

Issue link

https://issues.redhat.com/browse/RHOAIENG-11541

What changes have been made

Added another version of python to be installed as part of GH action in accordance with this documentation

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2024
@KPostOffice
Copy link
Collaborator Author

https://github.com/KPostOffice/notebooks/pull/1/files

See example PR from this workflow (successfully updates 3.11 Pipfiles

@KPostOffice KPostOffice marked this pull request as ready for review September 5, 2024 00:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2024
@openshift-ci openshift-ci bot requested review from Bobbins228 and dimakis September 5, 2024 00:33
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
Signed-off-by: Kevin <kpostlet@redhat.com>
@KPostOffice KPostOffice force-pushed the nb-sync-RHOAIENG-11541 branch from 6a3e843 to b821d01 Compare September 9, 2024 19:13
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
Signed-off-by: Kevin <kpostlet@redhat.com>
@KPostOffice KPostOffice force-pushed the nb-sync-RHOAIENG-11541 branch from b821d01 to 33b4fd5 Compare September 10, 2024 14:42
@KPostOffice
Copy link
Collaborator Author

Accidentally opened this PR upstream with the changes to the workflow file but it's here

opendatahub-io/notebooks#698

@KPostOffice
Copy link
Collaborator Author

@Bobbins228 PTAL

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
nice work on shaving down the "Extracting only directories from file paths" step!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
Copy link
Contributor

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1! Like grep over the script!

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 29efd33 into project-codeflare:main Sep 11, 2024
12 checks passed
jstourac added a commit to jstourac/codeflare-sdk that referenced this pull request Sep 28, 2024
This is a followup of project-codeflare#655 where the Pipfile.cpu and Pipfile.gpu support
was broken. Apart from that - the array initialization was fixed and the
link to this workflow is added to the raised PR description.
openshift-merge-bot bot pushed a commit that referenced this pull request Sep 30, 2024
This is a followup of #655 where the Pipfile.cpu and Pipfile.gpu support
was broken. Apart from that - the array initialization was fixed and the
link to this workflow is added to the raised PR description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants