Fixes #1230, adding ES Module output #1621
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,9 +300,6 @@ export class FieldBase extends ReflectionObject { | |||
| */ | |||
| constructor(name: string, id: number, type: string, rule?: (string|{ [k: string]: any }), extend?: (string|{ [k: string]: any }), options?: { [k: string]: any }, comment?: string); | |||
|
|
|||
| /** Field rule, if any. */ | |||
| public rule?: string; | |||
There was a problem hiding this comment.
Not sure why the .d.ts file is changed in this PR, is it intended?
There was a problem hiding this comment.
Seems to be a consequence of running build again, I suspect its been changed in some other commit but the project hasn't been fully rebuilt since?
|
@bcoe @alexander-fenster what is the state of this PR? Do you intend to land this? |
5 tasks
|
This is missing the cli exports. I'm trying these changes with https://github.com/steinybot/protobufjs-webpack-plugin and it fails with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at adding an ES Module build output using a Rollup build process similar to the existing browserify one.
I think this should work but will likely need some further testing to be sure as I haven't yet used this in a project.
While this PR does not touch any of the existing build outputs, it does add an
exportsfield to thepackage.jsonto map the imports to either the existing CJS or the new ESM builds. This change can be a breaking change since it effectively isolates the interface to the package in modern resolvers, I believe I have however mapped all the existing intended exports of this package using this field but should probably get confirmation of this also.