Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max line length with bugbear #3731

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Max line length with bugbear #3731

merged 3 commits into from
Jun 12, 2023

Conversation

Alveel
Copy link
Contributor

@Alveel Alveel commented Jun 12, 2023 •
edited
Loading

Description

Fixes #3716

The current phrasing of the Flake8 section of the line length documentation is very open.

This PR makes it more concise and explicit, as well as change the max-line-length example when using flake8-bugbear to 80, as explained in #3716.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

Alveel added 2 commits June 12, 2023 09:59
@Alveel
Make phrasing for flake8 users more concise
7364c21 
max-line-length should be 80 with flake8-bugbear
Fixes #3716
@Alveel
Re-add rationale and an explanation for
73b49c4 
disabling E203
@Alveel
Copy link
Contributor Author

Alveel commented Jun 12, 2023

I don't think an entry in CHANGES.md and adding/updating tests is necessary for this change, because:

  1. what the documentation says is essentially the same
  2. only documentation is updated, no code changes are made

@Alveel
Copy link
Contributor Author

Alveel commented Jun 12, 2023

Is it okay to add a header for flake8 or should I remove that? I noticed it would be the only third-level header in the page 😇

cooperlees
cooperlees approved these changes Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cooperlees cooperlees added the skip news Pull requests that don't need a changelog entry. label Jun 12, 2023
@cooperlees cooperlees merged commit 35722df into psf:main Jun 12, 2023
@Alveel Alveel deleted the max-line-length-with-bugbear branch June 13, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shouldn't max-line-length be 80 when using bugbear?
2 participants
@Alveel @cooperlees