Fixes for various errors #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubnub/models/consumer/common.py
Outdated
| @@ -20,4 +20,4 @@ def __init__(self): | |||
| self.affected_groups = None | |||
|
|
|||
| def is_error(self): | |||
| return self.error is not None | |||
| return True if self.error else False | |||
There was a problem hiding this comment.
You can also try with:
return bool(self.error)
It should return the same results ;)
| packages=find_packages(exclude=("examples*", 'tests*')), | ||
| license='MIT', | ||
| classifiers=( | ||
| 'Development Status :: 5 - Production/Stable', | ||
| 'Intended Audience :: Developers', | ||
| 'Programming Language :: Python', | ||
| 'Programming Language :: Python :: 3.6', | ||
| 'Programming Language :: Python :: 3.7', |
There was a problem hiding this comment.
Based on python_requires this package should work with Python 3.7
marek-lewandowski
approved these changes
Nov 22, 2022
|
@client-engineering-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fix typo in consumers v3
This change fixes typo in consumer models user and space resulting in setting invalid flags for the request.
fix: Fix method
is_errorin common modelThis change fixes error in calling and returning value of
status.is_error()methodfix: Add misc informations to PyPi package
This change adds additional informations to PyPi package. Informations include URLs to source code and documentation, required python version (at least 3.7) and updates a list of supported python versions (removed 3.6 and added 3.10)
Closes #145
Closes #102
Closes #115