Skip to content

Add compiler_pool_{a,b}_address parameters #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2020
Merged

Add compiler_pool_{a,b}_address parameters #121

merged 1 commit into from
Sep 15, 2020

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Sep 15, 2020

These are necessary to fully configure large and extra large architectures.

@reidmv reidmv requested a review from a team as a code owner September 15, 2020 02:36
@trlinkin
Copy link
Contributor

@reidmv It appears to me that the purpose of compiler_pool_address and compiler_pool_{a|b}_address are different enough that having them named so similarly could be confusing. Either a slightly different name making the purpose of compiler_pool_address more obvious of some extended docs could help.

@reidmv
Add compiler_pool_{a,b}_address parameters
7a76f06 
These are necessary to fully configure large and extra large
architectures.
@reidmv reidmv force-pushed the compiler-pool-addresses branch from e786d82 to 7a76f06 Compare September 15, 2020 18:03
trlinkin
trlinkin approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@trlinkin trlinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameters add an important level of control. Everything is clearly stated and good to go.

@trlinkin trlinkin merged commit d2332cc into main Sep 15, 2020
@reidmv reidmv deleted the compiler-pool-addresses branch September 17, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trlinkin trlinkin trlinkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reidmv @trlinkin