Improve error handling of peadm::download task #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `peadm::download` task would exit with
"success" when S3 returned a "404 Not Found" error page. This
would happen when a PE version was reqeusts that did not support
the OS platforms being provisioned. E.g. requesting an install of
PE 2018.1 on RedHat 8. The provisioning plan would then blow
later when `tar` found an XML document instead of a gzipped archive.
This commit updates the download task to:
- Print the URL being downloaded to stderr.
- Pass the `-f` flag to `curl` when downloading tarballs.
This causes curl to exit with a status of 22 if the
HTTP response is an error.
|
👍 LGTM, thanks @Sharpie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
peadm::downloadtask would exit with"success" when S3 returned a "404 Not Found" error page. This
would happen when a PE version was reqeusts that did not support
the OS platforms being provisioned. E.g. requesting an install of
PE 2018.1 on RedHat 8. The provisioning plan would then blow
later when
tarfound an XML document instead of a gzipped archive.This commit updates the download task to:
Print the URL being downloaded to stderr.
Pass the
-fflag tocurlwhen downloading tarballs.This causes curl to exit with a status of 22 if the
HTTP response is an error.