Add DML IV #218
Merged
Add DML IV #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
force-pushed
the
kebatt/dmliv
branch
3 times, most recently
from
6291b3b to
80bd312
Compare
moprescu
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
Overall looks good. I left some minor comments here an there. Also, this should have an entry in the econml docs, especially if this will be in a minor release. Tests are also a must, even if there is just one dummy test per method. Just to make sure things run end-to-end.
kbattocchi
force-pushed
the
kebatt/dmliv
branch
2 times, most recently
from
f355fb0 to
e68dd4d
Compare
kbattocchi
force-pushed
the
kebatt/dmliv
branch
from
9c259cc to
cf3ef33
Compare
kbattocchi
force-pushed
the
kebatt/dmliv
branch
from
cf3ef33 to
5f85fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.