Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate n_splits with cv #362

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Deprecate n_splits with cv #362

merged 4 commits into from
Jan 12, 2021

Conversation

vsyrgkanis
Copy link
Collaborator

No description provided.

@vsyrgkanis vsyrgkanis added the enhancement New feature or request label Jan 4, 2021
@vsyrgkanis vsyrgkanis force-pushed the vasilis/deprecate_n_splits branch 2 times, most recently from b5d9576 to 09c2b30 Compare January 4, 2021 17:36
@vsyrgkanis vsyrgkanis changed the title Vasilis/deprecate n splits Deprecate n_splits with cv Jan 6, 2021
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few typos unrelated to your changes, but otherwise looks good.

fixed test ortho learner

fixed n_splits default
@kbattocchi kbattocchi force-pushed the vasilis/deprecate_n_splits branch from 09c2b30 to 899ae83 Compare January 12, 2021 18:01
@vsyrgkanis vsyrgkanis merged commit 1dd73c7 into master Jan 12, 2021
@vsyrgkanis vsyrgkanis deleted the vasilis/deprecate_n_splits branch January 12, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants