-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add back play button, as well as dimension size label #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 84.56% 84.76% +0.20%
==========================================
Files 45 45
Lines 4521 4633 +112
==========================================
+ Hits 3823 3927 +104
- Misses 698 706 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@gselzer ... happy enough with this addition? (still needs to be added to other backends... but mostly I want it in Qt for now) |
I like the current changes! I'd be happy if we added an issue to remind ourselves to add play buttons to the other frontends in the future. Couple bugs I found while testing, included in the video below:
Recording.2025-04-01.095221.mp4 |
Oh, another question for you - do you think it makes sense to make the play button a part of the viewer state (i.e. should we add a |
I do! And actually, even the “play” (Boolean) state and the fps might as well go on the model too? |
Maybe, although I'd think that those would be better suited for the |
ok i added the visibility to the viewer model. didn't do the play status yet. can be done later when we decide where to put it. ready for final review, and you can merge if you're happy with it @gselzer |
Looks good to me! Added a quick test for the play button visibility, and filed a few issues for the TODO items. LGTM |
Thanks! |
Untitled.mov