Skip to content

feat: add back play button, as well as dimension size label #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 3, 2025

Conversation

tlambert03
Copy link
Member

Untitled.mov

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 93.65079% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.76%. Comparing base (428fd96) to head (06af565).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ndv/views/_qt/_array_view.py 93.60% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   84.56%   84.76%   +0.20%     
==========================================
  Files          45       45              
  Lines        4521     4633     +112     
==========================================
+ Hits         3823     3927     +104     
- Misses        698      706       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
Copy link
Member Author

@gselzer ... happy enough with this addition? (still needs to be added to other backends... but mostly I want it in Qt for now)

@gselzer
Copy link
Collaborator

gselzer commented Apr 1, 2025

I like the current changes! I'd be happy if we added an issue to remind ourselves to add play buttons to the other frontends in the future.

Couple bugs I found while testing, included in the video below:

  • On Windows, at least, the FPS increment button does not work. The icons displayed on the buttons also look strange, although I'm not sure why that would be.
  • If you press the play button on an axis that later disappears, the spinner movie should stop. Happens when transitioning grayscale -> composite and 2D->3D
Recording.2025-04-01.095221.mp4

@gselzer
Copy link
Collaborator

gselzer commented Apr 1, 2025

Oh, another question for you - do you think it makes sense to make the play button a part of the viewer state (i.e. should we add a ArrayViewerModel.show_play_button?)

@tlambert03
Copy link
Member Author

I do! And actually, even the “play” (Boolean) state and the fps might as well go on the model too?

@gselzer
Copy link
Collaborator

gselzer commented Apr 2, 2025

And actually, even the “play” (Boolean) state and the fps might as well go on the model too?

Maybe, although I'd think that those would be better suited for the ArrayDisplayModel (man, we might want to think about easier names to differentiate)

@tlambert03
Copy link
Member Author

ok i added the visibility to the viewer model. didn't do the play status yet. can be done later when we decide where to put it. ready for final review, and you can merge if you're happy with it @gselzer

@gselzer
Copy link
Collaborator

gselzer commented Apr 3, 2025

Looks good to me! Added a quick test for the play button visibility, and filed a few issues for the TODO items.

LGTM

@gselzer gselzer merged commit a2e1442 into pyapp-kit:main Apr 3, 2025
51 checks passed
@tlambert03
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants