Always apply per-file schema during parquet read #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 4, 2025
| // Don't load the page index yet - we will decide later if we need it | ||
| let options = ArrowReaderOptions::new().with_page_index(false); | ||
|
|
||
| // Don't load the page index yet. Since it is not stored inline in |
There was a problem hiding this comment.
this is all comments and renaming variables so they better reflect what they are (metadata --> reader_metadata for example to distinguish between ParquetMetaData)
| if let Some(merged) = | ||
| apply_file_schema_type_coercions(&table_schema, &physical_file_schema) | ||
| { | ||
| physical_file_schema = Arc::new(merged); | ||
| options = options.with_schema(Arc::clone(&physical_file_schema)); |
There was a problem hiding this comment.
Ths is the actual fix -- to update reader_metadata here
zhuqi-lucas
reviewed
Apr 5, 2025
| let options = ArrowReaderOptions::new().with_page_index(false); | ||
|
|
||
| // Don't load the page index yet. Since it is not stored inline in | ||
| // the footer, loading the page index if it is not needed will do |
There was a problem hiding this comment.
this is some of the trickiest code in the parquet reader I think
adriangb
added a commit
that referenced
this pull request
Apr 6, 2025
… ParquetOpener (apache#15561) * parquet reader: move pruning predicate creation from ParquetSource to ParquetOpener * use file schema, avoid loading page index if unecessary * Add comment * add comment * Add comment * remove check * fix clippy * update sqllogictest * restore to explain plans * reverted * modify access * Fix ArrowReaderOptions should read with physical_file_schema so we do… (#17) * Fix ArrowReaderOptions should read with physical_file_schema so we don't need to cast back to utf8 * Fix fmt * Update opener.rs * Always apply per-file schema during parquet read (#18) * Update datafusion/datasource-parquet/src/opener.rs --------- Co-authored-by: Qi Zhu <821684824@qq.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target parquet reader: move pruning predicate creation from ParquetSource to ParquetOpener apache/datafusion#15561
Follow on to @zhuqi-lucas's PR Fix ArrowReaderOptions should read with physical_file_schema so we do… #17
#17 figured out the root cause of the problem (not updating the metadata used to create a reader) but I think it only applies when there is a page index to load. The clickbench queries in particular do not have page indexes so the code is skipped
I updated the code to always update the reader_metadata