Skip to content

Fix: Docs generation create temporary files that are not cleaned up. #10238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2025
Merged

Fix: Docs generation create temporary files that are not cleaned up. #10238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3dccbb
fix: added cleanup code for tmp time-series files
andrewendlinger Apr 20, 2025
b1d62f2
fix: added cleanup code for tmp saved_on_disk.h5 file
andrewendlinger Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions doc/internals/time-coding.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,3 +535,20 @@ To opt-out of timedelta decoding (see issue `Undesired decoding to timedelta64 <
.. note::
Note that in the future the default value of ``decode_timedelta`` will be
``False`` rather than ``None``.



.. ipython:: python
:suppress:

# Cleanup
import os

for f in [
"test-datetimes1.nc",
"test-datetimes2.nc",
"test-timedeltas1.nc",
"test-timedeltas2.nc",
]:
if os.path.exists(f):
os.remove(f)
5 changes: 4 additions & 1 deletion doc/user-guide/io.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,7 +1356,10 @@ To export just the dataset schema without the data itself, use the
# However, `ds` (rather than the unpickled dataset) refers to the open file. Delete
# `ds` to close the file.
del ds
os.remove("saved_on_disk.nc")

for f in ["saved_on_disk.nc", "saved_on_disk.h5"]:
if os.path.exists(f):
os.remove(f)

This can be useful for generating indices of dataset contents to expose to
search indices or other automated data discovery tools.
Expand Down
Loading