Refactor (part of) dataset.py to use explicit indexes #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Jan 21, 2019
xarray/core/dataset.py
Outdated
| @@ -244,6 +250,10 @@ def _assert_empty(args, msg='%s'): | |||
| raise ValueError(msg % args) | |||
|
|
|||
|
|
|||
| def _none_or_copy(arg): | |||
| return arg if arg is None else arg.copy() | |||
There was a problem hiding this comment.
nit, but given that we define __copy__ on xarray objects, could this be copy.copy(arg), and be dispatched appropriately?
There was a problem hiding this comment.
This is actually only used on builtin types like dict or OrderedDict. So indeed this is a safe (and superior) approach.
|
I'm going to merge this shortly, unless there are any objections. |
dcherian
pushed a commit
to yohai/xarray
that referenced
this pull request
Feb 14, 2019
* master: typo in whats_new (pydata#2763) Update computation.py to use Python 3 function signatures (pydata#2756) add h5netcdf+dask tests (pydata#2737) Fix name loss when masking (pydata#2749) fix datetime_to_numeric and Variable._to_numeric (pydata#2668) Fix mypy errors (pydata#2753) enable internal plotting with cftime datetime (pydata#2665) remove references to cyordereddict (pydata#2750) BUG: Pass kwargs to the FileManager for pynio engine (pydata#2380) (pydata#2732) reintroduce pynio/rasterio/iris to py36 test env (pydata#2738) Fix CRS being WKT instead of PROJ.4 (pydata#2715) Refactor (part of) dataset.py to use explicit indexes (pydata#2696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the larger project in #1603
None of this should change public APIs: we're simply making updating indexes explicit (via the
indexesdict) rather than implicit (through variables).