This repository was archived by the owner on Aug 15, 2021. It is now read-only.
Use slice::iter instead of into_iter to avoid future breakage
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`an_array.into_iter()` currently just works because of the autoref feature, which then calls `<[T] as IntoIterator>::into_iter`. But in the future, arrays will implement `IntoIterator`, too. In order to avoid problems in the future, the call is replaced by `iter()` which is shorter and more explicit.
|
Thank you! |
|
@pyfisch Not to rush anyone, but could this change be released as 0.10.3? Lots of crates depend on this one, so getting this fix out soon would be great :) |
|
Done. But I doubt that this will help much as many crates still depend on v0.9 and some even on v0.8 and earlier releases. |
|
@pyfisch Thanks a bunch! Unfortunately, I was not particularly smart regarding this PR. The same happened for At least we are completely done here now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an_array.into_iter()currently just works because of the autoreffeature, which then calls
<[T] as IntoIterator>::into_iter. Butin the future, arrays will implement
IntoIterator, too. In orderto avoid problems in the future, the call is replaced by
iter()which is shorter and more explicit.
A crater run showed that your crate is affected by a potential future
change. See rust-lang/rust#65819 for more information.