-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Updating docstring of a class according to PEP 257 in a file #4449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@michaelosthege Kindly review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the numpydoc formatting should be kept and change only where the docstring is, I don't think napoleon supports that format.
Can you generate docs locally? I amnactually not sure if there is any documentation on how to do so anywhere
Yes, the formatting of the |
pymc3/step_methods/metropolis.py
Outdated
"""Create an instance of a Metropolis stepper | ||
|
||
Arguments: | ||
vars -- List of variables for sampler (default None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very different from all our other doc strings which follow the numpy style guide, can you make it adhere to that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh Sorry! My bad. I will fix it right away
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @twiecki : )
Thanks @ashish-hacker! |
Thanks @twiecki for merging. Can I do this for all the classes for all the files? |
If the entire codebase docstrings are to be moved, it will be a good idea to ensure they follow numpy style using pydocstyle and fix them alongside. See #3713 |
link to the concerned issue #4414
Depending on what your PR does, here are a few things you might want to address in the description:
link to the changed docstrings