Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing runtime dependency on pip #646

Closed
stanislavlevin opened this issue May 15, 2023 · 2 comments · Fixed by #647
Closed

Missing runtime dependency on pip #646

stanislavlevin opened this issue May 15, 2023 · 2 comments · Fixed by #647

Comments

@stanislavlevin
Copy link
Contributor

According to docs https://flit.pypa.io/en/stable/cmdline.html#flit-install:

Flit calls pip to do the installation.

but pip is not specified as runtime dependency of flit.
@takluyver
Copy link
Member

Hmmm, good point. I think I just assume pip is always present, which naturally is not really true. Do you want to make a PR?

stanislavlevin added a commit to stanislavlevin/flit that referenced this issue May 16, 2023
@stanislavlevin
deps: Add missing runtime dependency on pip
758006f 
According to docs https://flit.pypa.io/en/stable/cmdline.html#flit-install:
> Flit calls pip to do the installation.

but pip was not specified as runtime dependency of flit.

Fixes: pypa#646
Signed-off-by: Stanislav Levin <slev@altlinux.org>
@stanislavlevin stanislavlevin mentioned this issue May 16, 2023
Merged
@orsinium
Copy link
Contributor

Project dependencies specify packages to be installed in the same environment as flit. However, flit currently uses pip installed in the target environment, which may be changed by passing --python flag. I'm going to change this behavior in #651 to make flit use pip from the flit's environment if available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: Add missing runtime dependency on pip stanislavlevin/flit
3 participants
@takluyver @orsinium @stanislavlevin