Eagerly import self_outdated_check when modifying pip
#12684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The self_outdated_check module should be loaded *before* pip is replaced as otherwise the module is liable to blow up if there are any incompatibities between the self_outdated_check from new pip and the old pip already loaded.
pradyunsg
approved these changes
May 8, 2024
|
Actually, @ichard26 could you add a test for this failure mode as well? |
|
I likely won't get to it until this weekend, but sure I can add a test. |
|
FYI confirmed PR locally: |
No hurries on this; we can add this in follow up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
self_outdated_checkmodule should be loaded before pip is replaced as otherwise the module is liable to blow up if there are any incompatibities between theself_outdated_checkfrom new pip and the old pip already loaded.Alternative to #12676.
Fixes #12675.