-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate base_command.py's dependence on PipSession #6843
Conversation
e3774ed
to
2e970c5
Compare
2e970c5
to
505456f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be handy to add tests to verify that handle_pip_version_check is called in the correct scenarios.
ed8082e
to
9b1ece3
Compare
@pradyunsg Okay, I added some tests like this as you requested. I added--
|
7163ddd
to
234ef43
Compare
Hah! You're awesome @cjerdonek! |
This is a follow-on to PR #6835 that finishes removing
base_command.py
's dependency onindex.py
/PackageFinder
,PipSession
, andpip_version_check
, etc.This is again related to #4768 ("Speedup startup time").