Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move darwin special config dir to pip wrapper #7791

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Move darwin special config dir to pip wrapper #7791

merged 1 commit into from
Mar 23, 2020

Conversation

xavfernandez
Copy link
Member

This requires #7787 to be merged.

Related to #7705

@xavfernandez xavfernandez force-pushed the move_more_appdirs_patch branch 2 times, most recently from fe88737 to 484170e Compare February 28, 2020 10:34
@xavfernandez xavfernandez added the skip news Does not need a NEWS file entry (eg: trivial changes) label Mar 3, 2020
@xavfernandez xavfernandez marked this pull request as ready for review March 3, 2020 09:12
@chrahunt
Copy link
Member

chrahunt commented Mar 4, 2020

I think we should keep things which we would ideally upstream in the patch file, instead of bringing them into pip like this.

@xavfernandez
Copy link
Member Author

I think we should keep things which we would ideally upstream in the patch file, instead of bringing them into pip like this.

Our vendoring policy clearly states Vendored libraries MUST not be modified except as required to successfully vendor them.

So this PR is just trying to reduce the heavy patching of appdirs we perform to conform to our own policy.

This should not prevent us from actually upstreaming this patch.

@xavfernandez
Copy link
Member Author

This should not prevent us from actually upstreaming this patch.

I've opened ActiveState/appdirs#137

@xavfernandez xavfernandez force-pushed the move_more_appdirs_patch branch from 484170e to 633e17f Compare March 10, 2020 12:42
@xavfernandez xavfernandez merged commit d43699b into pypa:master Mar 23, 2020
@xavfernandez xavfernandez deleted the move_more_appdirs_patch branch March 23, 2020 18:31
@xavfernandez
Copy link
Member Author

Thanks for the review

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xavfernandez @chrahunt @uranusjr