Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joblib update to default -1 #138

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Joblib update to default -1 #138

merged 6 commits into from
Dec 4, 2023

Conversation

Ziqi-Li
Copy link
Member

@Ziqi-Li Ziqi-Li commented Dec 4, 2023

Update to n_jobs = -1 as default to use all processors. And to fix typo and make clarification in the example notebook.

@Ziqi-Li Ziqi-Li requested a review from martinfleis December 4, 2023 19:20
@martinfleis
Copy link
Member

Thanks!

What about that pool keyword causing hard-breaking change (#137 (comment))? That was the only point I though actually needs to be resolved, but these are nice to have as well!

@Ziqi-Li
Copy link
Member Author

Ziqi-Li commented Dec 4, 2023

Thanks!

What about that pool keyword causing hard-breaking change (#137 (comment))? That was the only point I though actually needs to be resolved, but these are nice to have as well!

How about this one with the new commit?
image

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. The rest looks great. Thanks!

Ziqi-Li and others added 3 commits December 4, 2023 17:27
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
@Ziqi-Li Ziqi-Li merged commit 5b484ef into pysal:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants