Skip to content

add esda.moran.Moran_BV visualizations to splot.esda #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 11, 2018

Conversation

slumnitz
Copy link
Member

Add moran_bv_scatterplot(), plot_moran_bv_simulation() and plot_moran_bv() to splot.esda

  • add functionality
  • add documentation
  • add tests
  • integrate in notebook

This PR is an addition to #17

@ljwolf
Copy link
Member

ljwolf commented Jun 29, 2018

the hdf5 error is bizarre. I've just tried restarting the build, so we'll see where that goes.

@ljwolf
Copy link
Member

ljwolf commented Jun 29, 2018

note that the hdf4/5 libraries are coming from conda-forge.

I think what we want is to append this to the config:
conda config --append channels conda-forge
so that only packages that aren't in conda are grabbed from conda forge.

@ljwolf
Copy link
Member

ljwolf commented Jun 29, 2018

Also, do you know what, exactly, we need from the forge? if so, we could just grab that only with a separate conda install -c conda-forge

@slumnitz
Copy link
Member Author

slumnitz commented Jun 29, 2018

Ok thank you, I can try and see what I can do about the conda-forge issues. Additionally I found this: conda-forge/geopandas-feedstock#28. I'll look into it later, it seems like the fix needs a bit of trial and error :)

@slumnitz
Copy link
Member Author

slumnitz commented Jun 30, 2018

It is still failing :( It seems to be this issue: conda-forge/fiona-feedstock#82. The conda-forge team is working on it at the moment.

@slumnitz
Copy link
Member Author

slumnitz commented Jul 2, 2018

@ljwolf all working now. :)

@sjsrey
Copy link
Member

sjsrey commented Jul 6, 2018

This looks good to me.

@ljwolf ljwolf merged commit 0deaa64 into pysal:master Jul 11, 2018
@slumnitz slumnitz deleted the viz-esda-moran branch August 3, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants