(ENH) speed up plot_spatial_weights for plotting spatial weights #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjsrey
approved these changes
Dec 31, 2018
|
Could we please get this to replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to pysal/libpysal#123 regarding the faster plotting of spatial weights for a large data set. The current plot_spatial_weights function in splot seems to be essentially the same as the plot method for W in libpysal, both of which take a long time for a large data set.
An example is given in this notebook which tries to visualize the queen weight for a data set containing 4109 polygons. The implementations in splot and libpysal cost about 500 seconds while the updated implementation costs about 3 seconds.