Skip to content

code 139 memory segmentation fault: RESOLVED #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 29, 2019

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Mar 11, 2019

The justification for this PR is:

  • This is an experiment whereby each testing script in splot/tests/ is limited to only one defined test each. It seems that segfault code 139 may have something to do with running out of memory.

  • No tests ended up needing to be changed. The issue was due to conflicting conda channels.

@jGaboardi jGaboardi added the bug label Mar 19, 2019
@jGaboardi jGaboardi requested review from slumnitz and sjsrey March 19, 2019 16:47
@jGaboardi
Copy link
Member Author

@slumnitz @sjsrey

Travis tests now passing. Once this is reviewed and merged it will very likely solve the ongoing pysal/pysal build failure.

The issue was very likely due to conda mixing conda-forge and default channels during conda install, causing fiona, etc. issues. Also, there was a pysal import that was causing problems that I swapped out for spreg.

@jGaboardi jGaboardi self-assigned this Mar 19, 2019
@jGaboardi jGaboardi changed the title limiting tests for memory segfault experiement code 139 memory segmentation fault: RESOLVED Mar 19, 2019
Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link
Member

@slumnitz slumnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi James, awesome, thank you so much for fixing this! the only change I would make is to update your first PR comment, so we know later on that you did not change tests but are now getting things from the right condo channels.

@jGaboardi
Copy link
Member Author

@slumnitz My initial comment is updated. Reading for merge.

@slumnitz slumnitz merged commit d9a0fd1 into pysal:master Mar 29, 2019
@jGaboardi jGaboardi deleted the debug_segfault branch March 29, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants