Skip to content

ci: xdist with pluggymaster #4836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 26, 2019

No description provided.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 26, 2019

Relevant CI jobs passed, canceled others.

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #4836 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4836      +/-   ##
==========================================
- Coverage   95.75%   95.11%   -0.65%     
==========================================
  Files         113      113              
  Lines       25666    25163     -503     
  Branches     2505     2498       -7     
==========================================
- Hits        24577    23934     -643     
- Misses        770      895     +125     
- Partials      319      334      +15
Flag Coverage Δ
#linux 95.11% <ø> (-0.46%) ⬇️
#osx ?
#windows ?
Impacted Files Coverage Δ
testing/test_pathlib.py 91.17% <0%> (-8.83%) ⬇️
src/_pytest/pytester.py 80.93% <0%> (-6.25%) ⬇️
testing/test_parseopt.py 90.4% <0%> (-4.43%) ⬇️
src/_pytest/capture.py 90.49% <0%> (-3.86%) ⬇️
testing/test_tmpdir.py 95.16% <0%> (-3.81%) ⬇️
testing/test_pdb.py 95.37% <0%> (-3.73%) ⬇️
testing/deprecated_test.py 96.77% <0%> (-3.23%) ⬇️
src/_pytest/compat.py 93.96% <0%> (-2.57%) ⬇️
src/_pytest/doctest.py 94.2% <0%> (-2.2%) ⬇️
src/_pytest/pathlib.py 88.46% <0%> (-2.2%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd2f43...4eb40ef. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Feb 26, 2019

  • Included dc8c270 from features.
  • Also use xdist on Azure, and fix the env for py27-pluggymaster (it was just "pluggymaster" before, likely using the default testenv then?!).

@blueyed blueyed changed the title ci: Travis: use xdist with pluggymaster jobs ci: xdist with pluggymaster Feb 26, 2019
@blueyed blueyed requested a review from nicoddemus February 26, 2019 13:24
- TOXENV: "pypy"
PYTEST_NO_COVERAGE: "1"
# Specialized factors for py27.
- TOXENV: "py27-trial,py27-numpy,py27-nobyte"
- TOXENV: "py27-pluggymaster"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to touch this; when we adopt Azure for good, we will disable AppVeyor entirely, so it doesn't make much sense to change things mid way now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in features already: dc8c270

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind then! 😋

Besides #4807, we could adopt Azure as our official Windows build right away. I will try to get to it later.

@nicoddemus
Copy link
Member

Latest build from master:

  • py27-pluggymaster: 8m 27s (which was incorrect as you point out)
  • py37-pluggymaster: 7m 46s

This PR:

  • py27-pluggymaster-xdist: 7m 57s
  • py37-pluggymaster-xdist: 4m 38s

I'm disappointed we couldn't get better timings for p2y7, but for py37 it seems worth it (although I suspect this is due to the difference between the machines rather than a difference between Python versions).

@nicoddemus
Copy link
Member

  • Also use xdist on Azure, and fix the env for py27-pluggymaster (it was just "pluggymaster" before, likely using the default testenv then?!).

Oops!

@nicoddemus nicoddemus merged commit 7428064 into pytest-dev:master Feb 26, 2019
@blueyed blueyed deleted the travis-pluggymaster-xdist branch February 26, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants