-
-
Notifications
You must be signed in to change notification settings - Fork 133
Add anyOf #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anyOf #354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
- Coverage 96.72% 95.91% -0.82%
==========================================
Files 80 80
Lines 1743 1714 -29
==========================================
- Hits 1686 1644 -42
- Misses 57 70 +13
Continue to review full report at Codecov.
|
@p1c2u Could you please review this PR? Do you insist on covering the two currently uncovered sections? The equivalent sections for unmarshaling |
@p1c2u Tests are passing now. Would you mind doing a review? |
Closing in favor of #423 |
@@ -182,59 +190,51 @@ def unmarshal(self, value): | |||
else: | |||
return self._unmarshal_object(value) | |||
|
|||
def _clone(self, schema): | |||
return ObjectUnmarshaller( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sisp can you explain me please more why you create new unmarshaller with new schema but with old validator and formatter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I believe it's better to use the SchemaUnmarshallersFactory
instead. Not sure why I hadn't thought of that at the time.
I've created a PR: #425
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This is a continuation of #288 (thanks to @allcaps for your work).
I've addressed @p1c2u's comments in #288 and updated the branch to the latest state of
master
. Any feedback is most welcome. 🙂