Refuse to cast str or bytes to array #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
=======================================
Coverage 93.38% 93.39%
=======================================
Files 97 97
Lines 2344 2346 +2
Branches 292 293 +1
=======================================
+ Hits 2189 2191 +2
Misses 120 120
Partials 35 35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
p1c2u
force-pushed
the
array-cast
branch
2 times, most recently
from
7be7fcc to
a8c3729
Compare
Although str and bytes act as sequences in Python, they do not count as arrays according to OpenAPI, so we should not allow them to validate as arrays. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
p1c2u
approved these changes
Sep 13, 2022
|
@andersk thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
strandbytesact as sequences in Python, they do not count as arrays according to OpenAPI, so we should not allow them to validate as arrays.