Skip to content

Requests request response binary format support #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Requests request response binary format support #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion openapi_core/contrib/requests/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ def body(self) -> Optional[str]:
if self.request.body is None:
return None
if isinstance(self.request.body, bytes):
return self.request.body.decode("utf-8")
try:
return self.request.body.decode("utf-8")
except UnicodeDecodeError:
return self.request.body
assert isinstance(self.request.body, str)
# TODO: figure out if request._body_position is relevant
return self.request.body
Expand Down
5 changes: 4 additions & 1 deletion openapi_core/contrib/requests/responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ def __init__(self, response: Response):
@property
def data(self) -> str:
assert isinstance(self.response.content, bytes)
return self.response.content.decode("utf-8")
try:
return self.response.content.decode("utf-8")
except UnicodeDecodeError:
return self.response.content

@property
def status_code(self) -> int:
Expand Down