A $ref may be a property name and in such cases it's not hashable
#124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcivanov
force-pushed
the
issue_123
branch
2 times, most recently
from
8f5bb55 to
c72d85b
Compare
This is not a "proper fix" as the proper fix should check if `$ref` is used as a name of the property, but this works for the purposes of python-openapi#123 fixes python-openapi#123
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 98.26% 98.46% +0.19%
==========================================
Files 19 19
Lines 518 520 +2
==========================================
+ Hits 509 512 +3
+ Misses 9 8 -1
Continue to review full report at Codecov.
|
p1c2u
approved these changes
May 12, 2021
|
@arcivanov thank you for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a "proper fix" as the proper fix should check if
$refis used as a name of the property, but this works for the purposes of #123
fixes #123