Skip to content

Drop 3.6 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Drop 3.6 #207

merged 3 commits into from
Dec 13, 2022

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented Dec 8, 2022

GitHub is raggedly allowing 3.5 and 3.6 support in Linux to drop from the setup-python action as they start using Ubuntu 22.04 instead of 20.04. actions/setup-python#544

Example failure at https://github.com/python-qt-tools/PyQt5-stubs/actions/runs/3645895301/jobs/6156457796#step:3:9.

Version 3.6.0-alpha - 3.6.X was not found in the local cache
Error: Version 3.6.0-alpha - 3.6.X with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

We could also just make our matrix ragged as well and only drop the Linux testing. Or, explicitly call out the 20.04 runners for awhile. Let me know what you think.

Copy link
Collaborator

@The-Compiler The-Compiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! Python 3.6 is EOL since almost a year, so yeah, let's just drop it.

@altendky
Copy link
Collaborator Author

@bluebird75, i'm happy to try to hold on a bit longer by either using 20.04 explicitly or making a ragged matrix. Just want to make sure you get a chance at input here, if you'd like.

@altendky
Copy link
Collaborator Author

I'm going to go ahead and merge this for the sake of the rest of CI being clearly good or bad. Still happy to revert and do one of the other options if anyone requests.

@altendky altendky merged commit 7001800 into master Dec 13, 2022
@altendky altendky deleted the drop_3.6 branch December 13, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants