gh-109401: Fix threading barrier test_default_timeout() #109875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
added
tests
Increase timeouts. Barrier default timeout should be long enough to spawn 4 threads on a slow CI.
vstinner
force-pushed
the
barrier_timeout
branch
from
a24531d to
ca0d11e
Compare
|
This test is not reliable, it depends on time. I'm not sure how to make the test more reliable without using other synchronization primitives. But this test seems to be a test on a synchronization primitive, but it would be better to avoid using other synchronization primitives to test it... Well, I wrote the simplest workaround: increase timeouts. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2023
…GH-109875) Increase timeouts. Barrier default timeout should be long enough to spawn 4 threads on a slow CI. (cherry picked from commit e5186c3) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-109876 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2023
…GH-109875) Increase timeouts. Barrier default timeout should be long enough to spawn 4 threads on a slow CI. (cherry picked from commit e5186c3) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-109877 is a backport of this pull request to the 3.11 branch. |
|
2 tests failed on Windows x86:
|
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
…#109875) Increase timeouts. Barrier default timeout should be long enough to spawn 4 threads on a slow CI.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…#109875) Increase timeouts. Barrier default timeout should be long enough to spawn 4 threads on a slow CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase timeouts. Barrier default timeout should be long enough to spawn 4 threads on a slow CI.