Skip to content

[3.12] gh-124594: Create and reuse the same context for the entire asyncio REPL session (GH-124595) #124849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2024
Merged

[3.12] gh-124594: Create and reuse the same context for the entire asyncio REPL session (GH-124595) #124849

merged 4 commits into from
Oct 28, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 1, 2024 •
edited by bedevere-app bot
Loading

(cherry picked from commit 67e01a4)

Co-authored-by: Bartosz Sławecki bartoszpiotrslawecki@gmail.com
Co-authored-by: Andrew Svetlov andrew.svetlov@gmail.com

@bswck @asvetlov @miss-islington
pythongh-124594: Create and reuse the same context for the entire asy…
a393cde 
…ncio REPL session (pythonGH-124595)

(cherry picked from commit 67e01a4)

Co-authored-by: Bartosz Sławecki <bartoszpiotrslawecki@gmail.com>
Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Oct 1, 2024
Closed
@bedevere-app bedevere-app bot mentioned this pull request Oct 1, 2024
Merged
@bswck
Copy link
Contributor

bswck commented Oct 1, 2024 •
edited
Loading

The failure seems pretty quirky.

asyncio REPL 3.12.7+ (remotes/pull/124849/merge-dirty:fd216e1, Oct  1 2024, 14:24:15) [GCC 11.4.0] on linux
Use "await" directly instead of "asyncio.run()".
Type "help", "copyright", "credits" or "license" for more information.
>>> import asyncio
>>> >>> >>> ...   File "<console>", line 2
    await set_var()
    ^^^^^
SyntaxError: invalid syntax
>>> toplevel contextvar test: failed
>>>
exiting asyncio REPL...
>>>

(copied from CI)
I'll inspect that further on the 3.12 branch in a couple days.

@asvetlov asvetlov merged commit d89283b into python:3.12 Oct 28, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miss-islington @bswck @asvetlov