bpo-36818: Add PyInterpreterState.runtime field. #13129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
interp-runtime-field
branch
2 times, most recently
from
33fc33e to
7a22095
Compare
vstinner
requested changes
May 10, 2019
There was a problem hiding this comment.
I disagree with the overall approach. Maybe I misunderstood you.
https://bugs.python.org/issue36818#msg342043
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
|
Eric is working on a different approach: https://bugs.python.org/issue36854 |
|
The GC stuff is orthogonal to adding |
ericsnowcurrently
force-pushed
the
interp-runtime-field
branch
from
4ac4dcd to
410603d
Compare
ericsnowcurrently
requested review from
brettcannon,
encukou,
ncoghlan and
warsaw
as code owners
ericsnowcurrently
force-pushed
the
interp-runtime-field
branch
from
410603d to
5c2a483
Compare
|
FYI, I've trimmed the PR down. The changes I've removed can wait until later. |
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
)" (pythonGH-13795) This reverts commit 396e0a8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36818