Skip to content

Pass _asyncio_internal=True into stream tests on windows #13442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2019
Merged

Pass _asyncio_internal=True into stream tests on windows #13442

merged 1 commit into from
May 20, 2019

Conversation

asvetlov
Copy link
Contributor

To suppress DeprecationWarning in tests

@asvetlov asvetlov requested a review from 1st1 as a code owner May 20, 2019 12:57
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 20, 2019
tirkarthi
tirkarthi approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@asvetlov asvetlov merged commit 45a24b8 into python:master May 20, 2019
@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@asvetlov asvetlov deleted the suppress-asyncio-deprecation branch May 20, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @bedevere-bot @tirkarthi @the-knights-who-say-ni