Skip to content

bpo-42645: Make sure that return/break/continue are only traced once when exiting via a finally block. #23780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2020

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Dec 15, 2020

This PR:

  • Adds some tests from coverage.py
  • Makes sure that break, continue, and return are traced only once when exiting via a finally block.

Skipping news as this is part of PEP 626.

https://bugs.python.org/issue42645

@markshannon markshannon force-pushed the additional-tests-from-coverage branch from 1d0141c to 958f587 Compare December 16, 2020 12:29
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markshannon markshannon merged commit 5274b68 into python:master Dec 16, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…when exiting via a finally block. (pythonGH-23780)

* Make sure that return/break/continue are only traced once when exiting via a finally block.

* Add test for return in try-finally.

* Update importlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants