Skip to content

Fix dataclassses spelling #28837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2021
Merged

Fix dataclassses spelling #28837

merged 1 commit into from
Oct 9, 2021

Conversation

jly36963
Copy link
Contributor

@jly36963 jly36963 commented Oct 9, 2021

No description provided.

@jly36963 jly36963 requested a review from ericvsmith as a code owner October 9, 2021 17:59
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jly36963

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@ericvsmith
Copy link
Member

Given that this is a trivial change, I'm going to not require the CLA. But you should go ahead and sign it, anyway, for future contributions. Thanks!

@ericvsmith ericvsmith added the needs backport to 3.10 only security fixes label Oct 9, 2021
@ericvsmith ericvsmith merged commit 5b4a767 into python:main Oct 9, 2021
@miss-islington
Copy link
Contributor

Thanks @jly36963 for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2021
@jly36963 @miss-islington
Fix dataclassses spelling (pythonGH-28837)
ab5b1bc 
(cherry picked from commit 5b4a767)

Co-authored-by: Landon Yarrington <33426811+jly36963@users.noreply.github.com>
@bedevere-bot
Copy link

GH-28841 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 9, 2021
ericvsmith pushed a commit that referenced this pull request Oct 9, 2021
@miss-islington @jly36963
Fix dataclassses spelling (GH-28837) (GH-28841)
e086bfe 
(cherry picked from commit 5b4a767)

Co-authored-by: Landon Yarrington <33426811+jly36963@users.noreply.github.com>

Co-authored-by: Landon Yarrington <33426811+jly36963@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jly36963 @the-knights-who-say-ni @ericvsmith @miss-islington @bedevere-bot @Mariatta