Skip to content

Rip out weak mode #2213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum opened this issue Oct 3, 2016 · 2 comments
Closed

Rip out weak mode #2213

gvanrossum opened this issue Oct 3, 2016 · 2 comments
Assignees

Comments

@gvanrossum
Copy link
Member

There's currently something called "weak mode" that's labeled experimental, is used by nobody (AFAICT), likely buggy, and confuses readers of the implementation. Nobody cares about owning it. Therefore I propose to rip this out.

This would also close:

In its place, we can now specify various flags like check_untyped_defs or disallow_untyped_defs in glob-sections of mypy.ini (see http://mypy.readthedocs.io/en/latest/config_file.html#per-file-flags)

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 4, 2016

This sounds reasonable. There hasn't been recent user interest in the weak mode, and it increases mypy implementation complexity.

@gvanrossum gvanrossum self-assigned this Oct 4, 2016
@gvanrossum
Copy link
Member Author

Fixed by #2217.

gvanrossum referenced this issue Oct 4, 2016
Fixes #2212.

All that's left is some calls to in_checked_function(), which replaces
the old typing_mode_full() and typing_mode_none() (its negation after
the elimination of typing_mode_weak()).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants