Skip to content

RIP weak mode. #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2016
Merged

RIP weak mode. #2217

merged 1 commit into from
Oct 4, 2016

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Oct 4, 2016

Fixes #2213.

All that's left is some calls to in_checked_function(), which replaces
the old typing_mode_full() and typing_mode_none() (its negation after
the elimination of typing_mode_weak()).

Fixes #2212.

All that's left is some calls to in_checked_function(), which replaces
the old typing_mode_full() and typing_mode_none() (its negation after
the elimination of typing_mode_weak()).

The meaning of in_checked_function() is:

- True if --check-untyped-defs is set.
- True outside functions.
- True in annotated functions.
- False otherwise.
@gvanrossum gvanrossum merged commit dd71ddc into master Oct 4, 2016
@gvanrossum gvanrossum deleted the rip-weak branch October 4, 2016 23:05
@gvanrossum gvanrossum mentioned this pull request Oct 4, 2016
@gvanrossum
Copy link
Member Author

Sorry, that should be #2213.

@ddfisher
Copy link
Collaborator

ddfisher commented Oct 4, 2016

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants