Recompute class MROs in ThirdPass, to handle import loops #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -739,3 +739,18 @@ y = 42 | |||
| [builtins fixtures/module.py] | |||
| [out] | |||
| tmp/main.py:4: error: Unsupported left operand type for + ("int") | |||
|
|
|||
| [case testSuperclassInImportCycle] | |||
There was a problem hiding this comment.
Does this assume that import loops are processed in a particular order? If yes, as we might change the order in the future, it may be better to have another test case would demonstrate the issue if the modules in the import cycle were processed in the opposite order.
There was a problem hiding this comment.
Yes, good point. This test is sensitive to the import order. I added a second test with the imports in the main module reversed.
|
Looks good, just one question about the test case. |
Fixes python#1394. This is a bit of a hack, but at least it's simple.
rwbarton
force-pushed
the
rwbarton-loopy-superclasses
branch
from
0bdf24b to
690c494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1394. This is a bit of a hack, but at least it's simple.