Skip to content

Switch to using sha1 for hashes #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

Switch to using sha1 for hashes #8251

merged 1 commit into from
Jan 7, 2020

Conversation

msullivan
Copy link
Collaborator

Fixes #7976.

@msullivan
Copy link
Collaborator Author

Though this just dropped: https://sha-mbles.github.io/
We still don't really care about security implications but maybe stuff is about to start whining about sha1 also. (Which, you know, it should)

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 7, 2020

If the performance of SHA-256 isn't much worse than sha1, maybe we should just use it.

@emmatyping
Copy link
Member

Considering md5 was disabled in FIPS environments, and sha1 now has the same weaknesses as md5, I expect in future FIPS revisions sha1 will be unavailable, so I agree sha256 seems to make more sense for future proofing.

@msullivan msullivan merged commit 35b5039 into master Jan 7, 2020
@msullivan msullivan deleted the sha1 branch January 7, 2020 23:39
@msullivan
Copy link
Collaborator Author

I made it do sha256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Mypy uses MD5 which causes a traceback in FIPS environment
3 participants
@msullivan @JukkaL @emmatyping