Skip to content

tkinter: Use a TypeVarTuple in .after() and .after_idle() methods #11014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Nov 10, 2023

This ensures that you pass in the right number of arguments for the callback, and of the right type. TypeVarTuple didn't exist when the stubs were written.

Currently this crashes pytype.

@Akuli Akuli added the status: deferred Issue or PR deferred until some precondition is fixed label Nov 10, 2023

This comment has been minimized.

@Akuli Akuli changed the title Use a TypeVarTuple in tkinter.after() and tkinter.after_idle() tkinter: Use a TypeVarTuple in .after() and .after_idle() methods Nov 10, 2023

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 51ec2f0 into python:main Dec 8, 2023
@AlexWaygood AlexWaygood removed the status: deferred Issue or PR deferred until some precondition is fixed label Dec 8, 2023
@Akuli Akuli deleted the tkinter-unpack branch December 9, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants